This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Use pytorch-labs/tokenizers and remove tokenizer/ #1401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Use our shiny new repo https://github.com/pytorch-labs/tokenizers. Test Plan: Rely on CI jobs Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1401
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 45eb6ed with merge base 29428ef ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
Jack-Khuu
approved these changes
Dec 7, 2024
Contributor
Jack-Khuu
left a comment
Jack-Khuu
left a comment
There was a problem hiding this comment.
Outside of the linter, looks like the main change is UNWRAP to deref the tokenizer results. Does that sound right?
Contributor
Author
Yes exactly |
Contributor
Author
|
All green merging |
Jack-Khuu
added a commit
that referenced
this pull request
Dec 10, 2024
This reverts commit fff956c.
Jack-Khuu
added a commit
that referenced
this pull request
Dec 10, 2024
larryliu0820
added a commit
that referenced
this pull request
Dec 26, 2024
Jack-Khuu
pushed a commit
that referenced
this pull request
Jan 3, 2025
) * [retry] Use pytorch-labs/tokenizers and remove tokenizer/ (#1401) Summary: Retry of #1401 Test Plan: Re-run the repro command in #1413: ``` python3 torchchat.py generate llama3.2-1b-base --prompt "write me a story about a boy and his bear" ``` Reviewers: Subscribers: Tasks: Tags: * Use latest commit Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Try enabling _GLIBCXX_USE_CXX11_ABI Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Fix PUBLIC issue Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
vmpuri
pushed a commit
that referenced
this pull request
Feb 4, 2025
* Use pytorch-labs/tokenizers and remove tokenizer/ Summary: Use our shiny new repo https://github.com/pytorch-labs/tokenizers. Test Plan: Rely on CI jobs Reviewers: Subscribers: Tasks: Tags: * Fix pull.yml Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
vmpuri
pushed a commit
that referenced
this pull request
Feb 4, 2025
vmpuri
pushed a commit
that referenced
this pull request
Feb 4, 2025
) * [retry] Use pytorch-labs/tokenizers and remove tokenizer/ (#1401) Summary: Retry of #1401 Test Plan: Re-run the repro command in #1413: ``` python3 torchchat.py generate llama3.2-1b-base --prompt "write me a story about a boy and his bear" ``` Reviewers: Subscribers: Tasks: Tags: * Use latest commit Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Try enabling _GLIBCXX_USE_CXX11_ABI Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Fix PUBLIC issue Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Use our shiny new repo
https://github.com/pytorch-labs/tokenizers.
Test Plan: Rely on CI jobs
Reviewers:
Subscribers:
Tasks:
Tags: