-
Notifications
You must be signed in to change notification settings - Fork 248
README: Minor typos + Upsell Server #1131
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1131
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7488835 with merge base 5986ed2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| ``` | ||
| # Execute | ||
| python3 torchchat.py generate llama3.1 --device cpu --pte-path llama3.1.pte --prompt "Hello my name is" | ||
| python3 torchchat.py generate llama3.1 --pte-path llama3.1.pte --prompt "Hello my name is" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTE always defaults to CPU, no explicit arg needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any warnings in our codebase to tell users that? We've assumed that user has zero background knowledge related to EET.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, the logs will say it falls back to CPU (even if they ask for GPU)
| ``` | ||
| # Execute | ||
| python3 torchchat.py generate llama3.1 --device cpu --pte-path llama3.1.pte --prompt "Hello my name is" | ||
| python3 torchchat.py generate llama3.1 --pte-path llama3.1.pte --prompt "Hello my name is" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any warnings in our codebase to tell users that? We've assumed that user has zero background knowledge related to EET.
Miscellaneous README fixes + the server instructions out of a hidden dropdown (removes a click for testing browser)