This repository was archived by the owner on Sep 10, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 814
Remove torchdata dependency from package and from CI #2241
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/text/2241
Note: Links to docs will display an error until the docs builds have been completed. ❌ 19 New Failures, 5 Unrelated FailuresAs of commit 9e13774 with merge base 52c0d85 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
atalman
reviewed
Mar 22, 2024
| if channel == "nightly": | ||
| validateTorchdataVersion() | ||
|
|
||
| print("torchtext version is ", torchtext.__version__) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could include 1-2 basic torchtext functionalities tests, here to see if they work. This can be done in followup pr
atalman
approved these changes
Mar 22, 2024
PaliC
pushed a commit
that referenced
this pull request
Mar 22, 2024
PaliC
added a commit
that referenced
this pull request
Mar 22, 2024
Co-authored-by: Nicolas Hug <[email protected]> Fix torchdata import error (#2242)
PaliC
pushed a commit
that referenced
this pull request
Mar 23, 2024
huydhn
pushed a commit
that referenced
this pull request
Mar 23, 2024
huydhn
added a commit
that referenced
this pull request
Mar 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the dependency on torchdata:
setup.py/requirements.txt, etc.)The files that still have references to torchdata after this PR are:
The
torchtext.datasetsnamespace still relies on torchdata but that's OK: users who still need it can just install torchdata manually. Similarly I did not update/remove thetests/datasets/*files and instead just ignored all the dataset tests inpytest.ini.I will be submitting follow-up PRs to also address the user-facing docs, raise proper warnings, etc.