Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

@kit1980
Copy link
Contributor

@kit1980 kit1980 commented Jun 13, 2023

Add TorchFix linter and fix deprecated usages of assert_allclose to make it pass.

Also move the comments in the flake8 config to separate lines, as more modern flake8 versions do not support inline comments for any of the keys - https://flake8.pycqa.org/en/latest/user/configuration.html

The bandit failure and M1 failures are pre-existing.

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 13, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/text/2179

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures

As of commit 370019a:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@kit1980 kit1980 requested a review from a team June 13, 2023 00:40
@kit1980 kit1980 marked this pull request as ready for review June 13, 2023 00:55
Copy link
Member

@osalpekar osalpekar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kit1980
Copy link
Contributor Author

kit1980 commented Jun 13, 2023

The tests failing are also pre-existing, see the same errors on a dummy change #2180

So merging this PR.

@kit1980 kit1980 merged commit 60bea66 into main Jun 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants