This repository was archived by the owner on Sep 10, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 814
[Nova] Build docs in GHA #2170
Merged
Merged
[Nova] Build docs in GHA #2170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/text/2170
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New FailuresAs of commit fd6bdb5: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
approved these changes
May 16, 2023
.github/workflows/build-docs.yml
Outdated
Comment on lines
17
to
20
| strategy: | ||
| matrix: | ||
| python_version: ["3.8"] | ||
| fail-fast: false |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need a matrix here at all?
Suggested change
| strategy: | |
| matrix: | |
| python_version: ["3.8"] | |
| fail-fast: false |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
.github/workflows/build-docs.yml
Outdated
| git config --global --add safe.directory /__w/text/text | ||
|
|
||
| # Set up Environment Variables | ||
| export PYTHON_VERSION="${{ matrix.python_version }}" |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| export PYTHON_VERSION="${{ matrix.python_version }}" | |
| export PYTHON_VERSION="3.8" |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Nova] Build docs in GHA
Same as: pytorch/audio#3043