This repository was archived by the owner on Sep 10, 2025. It is now read-only.
[cherry-pick] Fix UTF8 decoding error in GPT2BPETokenizer decode method
#2092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: - PyBind11 throws an error when decoding a C++ `std::string` which contains incomplete UTF8 byte sequences since the default UTF8 conversion uses `"strict"` error handling ([ref](https://docs.python.org/3/library/codecs.html#error-handlers)) - To resolve user issues (see [post](https://fb.workplace.com/groups/pytorchtext/permalink/899318121386487/)) we set the error handling to `"ignore"` which ignores the malformed data and continues decoding the string Differential Revision: D43361716 fbshipit-source-id: 4ac488e4b4b894c8049728941a2ee36b1799258a
joecummings
approved these changes
Mar 2, 2023
Member
joecummings
left a comment
joecummings
left a comment
There was a problem hiding this comment.
Looks great! Thanks for doing this @Nayef211
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
std::stringwhich contains incomplete UTF8 byte sequences since the default UTF8 conversion uses"strict"error handling (ref)"ignore"which ignores the malformed data and continues decoding the stringDifferential Revision: D43361716
fbshipit-source-id: 4ac488e4b4b894c8049728941a2ee36b1799258a