Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

@joecummings
Copy link
Member

@joecummings joecummings commented Jan 27, 2023

Closes #2018

linux.2xlarge should have enough memory to run the integration tests.

Should only affect the Integration Tests (3.8) CPU CI workflow.

Copy link
Contributor

@Nayef211 Nayef211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update the PR description with details on why we're adding linux.2xlarge spec and what CI jobs/unit tests it fixes?

@joecummings
Copy link
Member Author

Can you please update the PR description with details on why we're adding linux.2xlarge spec and what CI jobs/unit tests it fixes?

Linked relevant issue

@joecummings joecummings merged commit 5b21235 into main Feb 2, 2023
@mthrok
Copy link
Contributor

mthrok commented Feb 2, 2023

@joecummings Is the change correct?
When I created PR #2040, the GHA immediately reported there is no integration test to run.

The workflow is not valid. .github/workflows/integration-test.yml (Line: 12, Col: 5): Unexpected value 'with'

https://github.com/pytorch/text/actions/runs/4070964869

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Increase memory for integration tests

5 participants