Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

@Geaming2002
Copy link
Contributor

NUM_LINES in torchtext/datasets/rte.py is wrong or maybe out of date (line 24). Update the information in the part

@facebook-github-bot
Copy link
Contributor

Hi @Geaming-CHN!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@joecummings
Copy link
Member

Hi @Geaming-CHN, thanks for the contribution! Can you please link in the PR where you found these updated numbers?

@Geaming2002
Copy link
Contributor Author

Hi @Geaming-CHN, thanks for the contribution! Can you please link in the PR where you found these updated numbers?

this link might help. https://www.tensorflow.org/datasets/catalog/glue#gluerte
or you just use the following codes in torchtext also can get the correct numbers

from torchtext.datasets import RTE
d1, d2, d3 = RTE()
print(len(list(d1)))
print(len(list(d2)))
print(len(list(d3)))
2490
277
3000

so u can see it, the code runs correctly but the numbers are wrong

Copy link
Contributor

@Nayef211 Nayef211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Geaming-CHN thanks for catching this, I think this must have been an oversight when the dataset was added.

@joecummings joecummings merged commit c776dc1 into pytorch:main Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants