Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Resolve inconsistency in IMDB label output #1914

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Resolve inconsistency in IMDB label output #1914

merged 1 commit into from
Sep 27, 2022

Conversation

@Nayef211
Copy link
Contributor

@Nayef211 Nayef211 commented Sep 27, 2022 •
edited
Loading

Description

Testing

  • pytest test/torchtext_unittest/datasets/test_imdb.py

Closes #1911

@Nayef211 Nayef211 marked this pull request as ready for review September 27, 2022 17:31
joecummings
joecummings approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@joecummings joecummings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joecummings joecummings mentioned this pull request Sep 27, 2022
Closed
@Nayef211 Nayef211 merged commit 52436c8 into pytorch:main Sep 27, 2022
@Nayef211 Nayef211 deleted the dataset/fix_imdb_label branch September 27, 2022 18:00
@Nayef211 Nayef211 mentioned this pull request Apr 17, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@abhinavarora abhinavarora Awaiting requested review from abhinavarora

1 more reviewer

@joecummings joecummings joecummings approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Nayef211 @joecummings @facebook-github-bot