This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Avoid to loop through the whole counter in bleu_score method #1913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joecummings
reviewed
Sep 27, 2022
|
|
||
| for ngram in candidate_counter: # TODO: no need to loop through the whole counter | ||
| total_counts[len(ngram) - 1] += candidate_counter[ngram] | ||
| for i in range(max_n): |
Member
There was a problem hiding this comment.
Can you add a one-line comment explaining the change?
Contributor
Author
There was a problem hiding this comment.
Thank you for your review! Sure!
joecummings
reviewed
Sep 27, 2022
Member
joecummings
left a comment
joecummings
left a comment
There was a problem hiding this comment.
Overall looks good, thanks for working on this. Just one nit
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In advance, thank you for this cool OSS!
There is a TODO comment in torchtext/data/metrics.py.
So, I made some changes based on the comment.
Would you be able to check them?