This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Testing T5Model #1848
Merged
Testing T5Model #1848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bbo13/text into feature/t5-integration-tests
Nayef211
approved these changes
Jul 20, 2022
|
|
||
| def test_t5_base_encoder_model(self): | ||
| expected_asset_name = "t5.base.encoder.output.pt" | ||
| model_input = torch.tensor([[1, 2, 3, 4, 5, 6], [7, 8, 9, 0, 0, 0]]) |
Contributor
There was a problem hiding this comment.
Just something to note, when we implement the transform for the model, we probably want to update the test to pass in an input string to the _t5_model method. The helper function will be responsible for applying the transform on the input string to get the tensor that can be passed into the model (code pointer). The T5Bundle class will also need to be updated to store the model transform as a member variable (code pointer).
Contributor
Author
There was a problem hiding this comment.
sounds good, will keep this in mind for the next task!
parmeet
approved these changes
Jul 20, 2022
Contributor
parmeet
left a comment
parmeet
left a comment
There was a problem hiding this comment.
Overall LGTM! Thanks for adding the integration test.
25 tasks
pmabbo13
added a commit
to pmabbo13/text
that referenced
this pull request
Jul 21, 2022
* test bundler api * upload reference results to verify model correctness * test for model correctness against reference results * Revert "test for model correctness against reference results" This reverts commit 9837f4a. * Revert "upload reference results to verify model correctness" This reverts commit bea35bc. * Revert "test bundler api" This reverts commit d8fe63e. * test bundler api * test bundler api * upload reference results to verify model correctness * test for model correctness against reference results * nit correction * test bundler when model is encoder-only * correcting typo * remove redundant test for encoder-only
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add integration tests for both the T5 model (encoder-only and encoder-decoder)
Process
test/asset/t5.base.encoder.output.pt,test/asset/t5.base.outputbuild_model(),get_model(),config()) are working as expected, and returning the correct error messages when invalid input args are provided.Testing
pytest test/prototype/integration_tests/test_models.pypytest test/prototype/models/test_models.pyFollow-Up