This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Fix Multi30k dataset urls #1816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parmeet
approved these changes
Jul 6, 2022
Contributor
parmeet
left a comment
parmeet
left a comment
There was a problem hiding this comment.
LGTM, thanks for providing the temporary fix. Although i am bit concerned changing the hash for test dataset (not sure what leads to this change), let's go ahead with this change to make the dataset usable.
Contributor
Author
@parmeet I was wondering the same thing but unfortunately I am not able to compare this test split against the test split of the original dataset as I don't have it readily available 😞 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description