Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

@suvigyajain0101
Copy link
Contributor

Ticks can result in re-direction to 'https://github.com/pytorch/data%60' instead of 'https://github.com/pytorch/data', which is not a valid resource.
Tested in Colab.

Ticks can result in re-direction to 'https://github.com/pytorch/data%60' instead of 'https://github.com/pytorch/data', which is not a valid resource.
Tested in Colab.
Copy link
Contributor

@Nayef211 Nayef211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for contributing to our repo @suvigyajain0101!

@Nayef211
Copy link
Contributor

@suvigyajain0101 if you have some time, would you mind updating this PR to also remove the ticks from the rest of our datasets? If not I can also do this in a followup PR 😄

@suvigyajain0101
Copy link
Contributor Author

@suvigyajain0101 if you have some time, would you mind updating this PR to also remove the ticks from the rest of our datasets? If not I can also do this in a followup PR 😄

@Nayef211
Sure. Happy to do this :) . Can you help me with an easier way to identify all the files where this issue might exist?

@Nayef211
Copy link
Contributor

Nayef211 commented May 31, 2022

@Nayef211 Sure. Happy to do this :) . Can you help me with an easier way to identify all the files where this issue might exist?

Awesome, thanks @suvigyajain0101! This issue exists in all of the files within the torchtext/datasets folder.

@suvigyajain0101
Copy link
Contributor Author

Hi @Nayef211 - I've updated the files under /torchtext/datasets folder and raised the PR - #1753

Let me know in case of any issues.
Thanks!
Suvigya

@Nayef211
Copy link
Contributor

Hi @Nayef211 - I've updated the files under /torchtext/datasets folder and raised the PR - #1753

Let me know in case of any issues. Thanks! Suvigya

Thanks @suvigyajain0101. Just accepted and merged the PR 😄

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants