This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Fix STSB and WikiTexts tests #1737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parmeet
requested review from
Nayef211 and
vcm2114
and removed request for
vcm2114
Nayef211
approved these changes
May 23, 2022
Contributor
Nayef211
left a comment
Nayef211
left a comment
There was a problem hiding this comment.
LGTM thanks for fixing the tests!
Contributor
|
I wonder why the build is segfaulting when running |
Contributor
Author
Ya, I am not so sure. I see same issues on audio CI (cc: @mthrok). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues with STSB and WikiTexts mocked testing. In both the cases mocked files were not written properly in their respective destinations.
fixes #1735
cc: @Nayef211 , @VirgileHlav , @VitalyFedyunin