-
Notifications
You must be signed in to change notification settings - Fork 814
Add support for MRPC dataset with unit tests #1712
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Please fix lint issues before merging :)
This seems weird to me. TorchData is required PyTorch to run some codegen. Based on the script (https://github.com/pytorch/text/blob/main/.circleci/unittest/linux/scripts/install.sh), it seems PyTorch is installed before TorchData. Not sure why this happens. text/.circleci/unittest/linux/scripts/install.sh Lines 32 to 33 in ab76a04
|
Maybe switching to install nightly with conda will help? |
@ejguan my mistake I guess we are relying on torchdata nightlies from pypi in our unit tests setup and not installing directly from source.
@NivekT do you know what the correct command would be to install the nightly from conda? text/.circleci/unittest/linux/scripts/install.sh Lines 32 to 33 in ab76a04
|
Nvm I just found the following link https://anaconda.org/pytorch-nightly/torchdata. I assume it would be as follows |
|
I think this command should be fine: |
Nayef211
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Delete print lines before merging
Summary
Test
pytest test/datasets/test_mrpc.pyContext
See #1710