Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

@abhinavarora
Copy link
Contributor

No description provided.

@abhinavarora abhinavarora requested review from Nayef211 and parmeet and removed request for parmeet February 17, 2022 17:47
Copy link
Contributor

@parmeet parmeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #1617 (38cbfd2) into main (c31a400) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1617      +/-   ##
==========================================
- Coverage   85.28%   85.25%   -0.03%     
==========================================
  Files          58       58              
  Lines        2488     2483       -5     
==========================================
- Hits         2122     2117       -5     
  Misses        366      366              
Impacted Files Coverage Δ
torchtext/datasets/ag_news.py 95.23% <ø> (-0.22%) ⬇️
torchtext/datasets/conll2000chunking.py 95.83% <ø> (-0.17%) ⬇️
torchtext/datasets/squad1.py 95.00% <ø> (-0.24%) ⬇️
torchtext/datasets/squad2.py 95.00% <ø> (-0.24%) ⬇️
torchtext/data/datasets_utils.py 74.66% <100.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c31a400...38cbfd2. Read the comment docs.

@abhinavarora abhinavarora merged commit ebabe82 into pytorch:main Feb 17, 2022
@abhinavarora abhinavarora deleted the fix_flake branch February 17, 2022 18:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants