Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

@Nayef211
Copy link
Contributor

@Nayef211 Nayef211 commented Feb 9, 2022

Summary

Test

pytest test_conll2000chunking.py

@Nayef211 Nayef211 requested a review from vcm2114 February 9, 2022 00:15
@Nayef211 Nayef211 requested a review from parmeet February 9, 2022 00:15
@Nayef211 Nayef211 changed the title Fixing Conll2000Chunking Test [BUG-FIX] Fixing Conll2000Chunking Test Feb 9, 2022
Copy link
Contributor

@vcm2114 vcm2114 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! LGTM

Copy link
Contributor

@parmeet parmeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #1595 (f85e2b0) into main (a2ab974) will decrease coverage by 3.74%.
The diff coverage is 84.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1595      +/-   ##
==========================================
- Coverage   85.89%   82.14%   -3.75%     
==========================================
  Files          57       58       +1     
  Lines        2389     2571     +182     
==========================================
+ Hits         2052     2112      +60     
- Misses        337      459     +122     
Impacted Files Coverage Δ
torchtext/datasets/iwslt2017.py 27.27% <23.91%> (-60.97%) ⬇️
torchtext/data/datasets_utils.py 58.99% <63.07%> (-21.85%) ⬇️
torchtext/datasets/dbpedia.py 96.15% <92.30%> (+0.15%) ⬆️
torchtext/datasets/penntreebank.py 95.23% <92.85%> (-4.77%) ⬇️
torchtext/datasets/conll2000chunking.py 96.00% <93.75%> (-4.00%) ⬇️
torchtext/datasets/wikitext103.py 96.00% <94.11%> (-4.00%) ⬇️
torchtext/datasets/wikitext2.py 96.00% <94.11%> (-4.00%) ⬇️
torchtext/datasets/udpos.py 96.00% <94.44%> (-4.00%) ⬇️
torchtext/transforms.py 96.00% <94.87%> (-0.36%) ⬇️
torchtext/datasets/enwik9.py 96.00% <95.23%> (-4.00%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccf021f...f85e2b0. Read the comment docs.

@Nayef211 Nayef211 merged commit 8c65757 into pytorch:main Feb 9, 2022
@Nayef211 Nayef211 deleted the hotfix/fix_conll2000chunking_test branch February 9, 2022 04:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants