This repository was archived by the owner on Sep 10, 2025. It is now read-only.
add CC100 mocking test #1583
Merged
add CC100 mocking test #1583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 tasks
Contributor
|
LGTM! |
Nayef211
approved these changes
Feb 7, 2022
Contributor
Nayef211
left a comment
Nayef211
left a comment
There was a problem hiding this comment.
Overall LGTM! I wonder if we should add the 2nd test for the split argument since this dataset also uses the @_wrap_split_argument decorator which means that it should be able to support both "train" and ("train",) for the split argument?
Contributor
Author
I think the split argument is bit superficial since the data does not really have splits. We might want to just remove this argument from the dataset. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue: #1493