This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Added caching to extracted files in DBPedia #1571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parmeet
approved these changes
Feb 4, 2022
Contributor
parmeet
left a comment
parmeet
left a comment
There was a problem hiding this comment.
LGTM! Please verify changes locally by completely wiping out the cached files.
Also in general, would be easier for reviewing by separate out linter related changes in different PR.
Contributor
Author
Sure thanks for the feedback. I think I have format on save enabled. Will disable this moving forward! |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue: #1589
Summary