Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Add UDPOS Mocked Unit Test #1569

Merged
merged 3 commits into from
Feb 3, 2022
Merged

Add UDPOS Mocked Unit Test #1569

merged 3 commits into from
Feb 3, 2022

Conversation

@vcm2114
Copy link
Contributor

@vcm2114 vcm2114 commented Feb 3, 2022

Reference Issue: #1493

Summary

  • Added mocked unit test for UDPOS dataset

Test

  • pytest test/datasets/test_udpos.py

@vcm2114 vcm2114 mentioned this pull request Feb 3, 2022
Closed
27 tasks
erip
erip reviewed Feb 3, 2022
View reviewed changes
Nayef211
Nayef211 approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@Nayef211 Nayef211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. When you merge in this PR, can you also make sure to update #1493 to check off that this dataset test is completed. Same goes for your other PRs 😄

@vcm2114 vcm2114 merged commit fdcbad2 into pytorch:main Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@erip erip erip left review comments

@Nayef211 Nayef211 Nayef211 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/default cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vcm2114 @erip @Nayef211 @facebook-github-bot