-
Notifications
You must be signed in to change notification settings - Fork 814
Merge YelpReviewPolarity and YelpReviewFull Mocked Unit Tests #1567
Conversation
|
Overall LGTM, but I think we might be able to combine YelpReviewPolarity with YelpReviewFull since they are almost similar except for number of classes and compressed filename. We could potentially pass these as arguments to |
@VirgileHlav you can look at #1575 for an example of how we parameterized the squad datasets |
parmeet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for merging the tests.
Reference Issue: #1493
Summary
Test
pytest test/datasets/test_yelpreviews.pyLeft to do