Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

@vcm2114
Copy link
Contributor

@vcm2114 vcm2114 commented Feb 3, 2022

Reference Issue: #1493

Summary

  • Merge mocked unit test for YelpReviewPolarity and YelpReviewFull dataset

Test

  • pytest test/datasets/test_yelpreviews.py

Left to do

@parmeet
Copy link
Contributor

parmeet commented Feb 5, 2022

Overall LGTM, but I think we might be able to combine YelpReviewPolarity with YelpReviewFull since they are almost similar except for number of classes and compressed filename. We could potentially pass these as arguments to _get_mock_dataset function. We could potentially combine AmazonReviewFull and AmazonReviewPolarity and I think @Nayef211 is going to combine Squad1 and Squad2 as well.

@Nayef211
Copy link
Contributor

Nayef211 commented Feb 7, 2022

Overall LGTM, but I think we might be able to combine YelpReviewPolarity with YelpReviewFull since they are almost similar except for number of classes and compressed filename. We could potentially pass these as arguments to _get_mock_dataset function. We could potentially combine AmazonReviewFull and AmazonReviewPolarity and I think @Nayef211 is going to combine Squad1 and Squad2 as well.

@VirgileHlav you can look at #1575 for an example of how we parameterized the squad datasets

@vcm2114 vcm2114 changed the title Add YelpReviewPolarity Mocked Unit Test Merge YelpReviewPolarity and YelpReviewFull Mocked Unit Tests Feb 8, 2022
Copy link
Contributor

@parmeet parmeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for merging the tests.

@parmeet parmeet merged commit 84b719e into pytorch:main Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants