Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

@vcm2114
Copy link
Contributor

@vcm2114 vcm2114 commented Jan 31, 2022

Reference Issue: #1493

Summary

  • Added mocked unit test for AmazonReviewFull dataset

Test

  • pytest test/datasets/test_amazonreviewfull.py

@erip
Copy link
Contributor

erip commented Jan 31, 2022

LGTM! It may be the case that eventually we'll want to abstract some of these repeated concepts (getting the dataset, populating the mock, etc.) into some common classes, but that's maybe a good TODO for later.

@Nayef211
Copy link
Contributor

LGTM! It may be the case that eventually we'll want to abstract some of these repeated concepts (getting the dataset, populating the mock, etc.) into some common classes, but that's maybe a good TODO for later.

LGTM as well! And totally agree with @erip. I will look into creating a base class that can handle some of the repeated logic across tests. For the time being, I think it's fine to get all of the tests implemented before the branch cut next week!

@Nayef211 Nayef211 merged commit 3f2c593 into pytorch:main Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants