This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Add EnWik9 Mocked Unit Test #1560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nayef211
reviewed
Jan 31, 2022
Contributor
Nayef211
left a comment
Nayef211
left a comment
There was a problem hiding this comment.
Thanks for taking this one @VirgileHlav. Added a couple of review comments. Should be good to merge this in once those are resolved 😄
27 tasks
Nayef211
approved these changes
Feb 3, 2022
Contributor
Nayef211
left a comment
Nayef211
left a comment
There was a problem hiding this comment.
LGTM. Let's resolve the NIT comments before we merge the PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue: #1493
Summary
Test
pytest test/datasets/test_enwik9.py