This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Revert BC breaking change in PennTreebank dataset #1555
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM! Qq, did tests not catch this? |
Contributor
Author
ya, they did, I learnt from there only for eg: https://app.circleci.com/pipelines/github/pytorch/text/4693/workflows/447cb44d-4ee2-4361-b954-2eebe700f25d/jobs/157132. Unfortunately, earlier the cache was broken though :( |
| data_dp = FileOpener(cache_dp, mode="r") | ||
| # remove single leading and trailing space from the dataset | ||
| return data_dp.readlines(return_path=False).map(lambda t: t.strip()) | ||
| return data_dp.readlines(return_path=False, strip_newline=False) |
Contributor
Wondering why did local testing not catch it? |
Contributor
Author
|
closing this PR as this is a reasonable BC breaking change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert the BC breaking change in the output introduced in #1511