Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

@parmeet
Copy link
Contributor

@parmeet parmeet commented Jan 28, 2022

This PR fix the bug in writing downloaded file to disk. It need be dumped as binary ('wb') and not as text/string ('w').

Copy link
Contributor

@abhinavarora abhinavarora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Nayef211 Nayef211 merged commit 9561cde into pytorch:main Jan 28, 2022
@parmeet parmeet deleted the fix_penn branch January 30, 2022 02:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants