Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

@erip
Copy link
Contributor

@erip erip commented Jan 28, 2022

Reference #1494

We can wait to review this until IWSLT2016 has landed to not duplicate efforts. 😄

@erip erip force-pushed the feature/migrate-IWSLT2017-datapipes branch from bf25959 to 54a663a Compare January 31, 2022 12:40
Copy link
Contributor

@Nayef211 Nayef211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @erip, this looks a lot cleaner! Left one more nit comment and this PR should be good to merge in once that's resolved

@Nayef211 Nayef211 merged commit 1f17c0a into pytorch:main Jan 31, 2022
@erip erip deleted the feature/migrate-IWSLT2017-datapipes branch January 31, 2022 19:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants