This repository was archived by the owner on Sep 10, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 814
migrate IWSLT2017 to datapipes. #1547
Merged
Nayef211
merged 8 commits into
pytorch:main
from
erip:feature/migrate-IWSLT2017-datapipes
Jan 31, 2022
Merged
migrate IWSLT2017 to datapipes. #1547
Nayef211
merged 8 commits into
pytorch:main
from
erip:feature/migrate-IWSLT2017-datapipes
Jan 31, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
bcaeedb to
35f0a9d
Compare
erip
commented
Jan 30, 2022
bf25959 to
54a663a
Compare
Nayef211
reviewed
Jan 31, 2022
Nayef211
approved these changes
Jan 31, 2022
Contributor
Nayef211
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @erip, this looks a lot cleaner! Left one more nit comment and this PR should be good to merge in once that's resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference #1494
We can wait to review this until IWSLT2016 has landed to not duplicate efforts. 😄