This repository was archived by the owner on Sep 10, 2025. It is now read-only.
[fbsync] Fixed file filtering bug in SST2 dataset #1444
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
splitis "test", the following snippet of codefilter(lambda x: split in x[0])might match all of the "train", "test", and "dev" files depending on the location of the dataset asset file/data/users/nayef211/fbsource/fbcode/buck-out/dev/gen/pytorch/text/test/experimental_test_datasets#binary,link-tree/test/asset/SST2/SST-2.zip/train.tsv. Since the word "test" is contained in this path string, the filtering logic would incorrectly select the "train" file even though what we want is the "test" filesplitvariable in the filtering logicReviewed By: parmeet
Differential Revision: D32329831
fbshipit-source-id: dbb4803a04f6cd50fab3f7ce5530d3258b2db012