Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

@cyyever
Copy link
Contributor

@cyyever cyyever commented Jun 13, 2021

Fix some warnings from clang-tidy due to the lack of parameter reference and using emplace_back to improve performance.

@parmeet
Copy link
Contributor

parmeet commented Jun 15, 2021

Thank you @cyyever for making the contribution. Could you please provide a short summary/description of the changes in the description box?

@parmeet
Copy link
Contributor

parmeet commented Jun 16, 2021

@cyyever Changes looks good to me..Do you think it would be useful to use emplace_back here as well?

@cyyever
Copy link
Contributor Author

cyyever commented Jun 17, 2021

@cyyever Changes looks good to me..Do you think it would be useful to use emplace_back here as well?

I have added.

@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #1327 (35fe716) into master (0d7b9e2) will increase coverage by 2.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1327      +/-   ##
==========================================
+ Coverage   76.43%   78.57%   +2.13%     
==========================================
  Files          67       67              
  Lines        3319     3319              
==========================================
+ Hits         2537     2608      +71     
+ Misses        782      711      -71     
Impacted Files Coverage Δ
torchtext/utils.py 91.66% <0.00%> (+5.83%) ⬆️
torchtext/vocab/vectors.py 89.69% <0.00%> (+38.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d7b9e2...35fe716. Read the comment docs.

Copy link
Contributor

@parmeet parmeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cyyever for your contributions in improving torchtext's C++ code-base :).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants