This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Streamlining download functionality using iopath #1319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parmeet
changed the title
This reverts commit 376c770.
Codecov Report
@@ Coverage Diff @@
## master #1319 +/- ##
==========================================
+ Coverage 76.85% 78.55% +1.69%
==========================================
Files 63 64 +1
Lines 3275 3315 +40
==========================================
+ Hits 2517 2604 +87
+ Misses 758 711 -47
Continue to review full report at Codecov.
|
seemethere
reviewed
Aug 23, 2021
| run: | ||
| - python | ||
| - requests | ||
| - iopath |
Member
There was a problem hiding this comment.
Is this actually available on anaconda?
I can't seem to find it anywhere?
This was referenced Aug 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces usage of iopath in download_from_url and cleans up the function by removing redundant logic flow.