-
Couldn't load subscription status.
- Fork 813
packaging: Specify cpuonly for conda meta.yaml #1106
Conversation
|
Sorry I am trying to understand what does "cpuonly" mean in this PR? Does it mean we only upload cpu version of torchtext nightly to conda (and by default |
Basically the way the conda dependency resolver works is that if we specify that we explicitly want The same works for |
|
Actually, @xuzhao9 made me realize that this might not be the best solution since it'd limit the |
Package installation for pytorch binaries was failing out due to conda/conda-package-handling#71 Default to cpuonly since that won't fail out. Signed-off-by: Eli Uriegas <[email protected]>
c2bf656 to
f1c7f7d
Compare
|
Okay I made a change that puts in more in line with what |
Codecov Report
@@ Coverage Diff @@
## master #1106 +/- ##
=======================================
Coverage 77.54% 77.54%
=======================================
Files 45 45
Lines 3086 3086
=======================================
Hits 2393 2393
Misses 693 693 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Package installation for pytorch binaries was failing out due to
conda/conda-package-handling#71
Default to cpuonly since that won't fail out.
Similar to pytorch/audio#1105
This should resolve issues within the nightly pipeline for conda builds
Signed-off-by: Eli Uriegas [email protected]