Change dependency update function to operate on index.html only rather then copy whls over #7487
+155
−99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r then copy whls over
|
@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
meta-cla
bot
added
the
CLA Signed
seemethere
approved these changes
Nov 18, 2025
zxiiro
approved these changes
Nov 18, 2025
ptrblck
reviewed
Nov 19, 2025
|
|
||
| def is_nvidia_package(pkg_name: str) -> bool: | ||
| """Check if a package is from NVIDIA and should use pypi.nvidia.com""" | ||
| return pkg_name.startswith("nvidia-") |
Contributor
There was a problem hiding this comment.
We might need to add more logic to this as not all packages start with nvidia-, e.g. https://pypi.org/project/cuda-bindings/ or https://pypi.org/project/cuda-cccl/ in case these will be added in the future. Not blocking for now, just leaving this as a comment for my future self.
ptrblck
approved these changes
Nov 19, 2025
nWEIdia
approved these changes
Nov 19, 2025
tinglvv
approved these changes
Nov 19, 2025
Contributor
Author
|
HI @tinglvv testing via validation framework. I am currently testing this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes : pytorch/pytorch#159409
We process index.html file rather then whl files. This will allow us to remove all conda and pypi dependencies from our s3 and CDN.
CUDA package example: https://pypi.nvidia.com/nvidia-cuda-nvrtc/
Simple pypi index example: https://pypi.org/simple/filelock/
Deployment strategy: