runners: Add terraform module for scale-cycle #6893
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Adds terraform files required for deploying scale-cycle. This also adds a switch to turn on scale-cycle or not with the default position being off. This should make it easier to deploy scale-cycle in the future and could also act as a gate for easily enabling / disabling scale-up's tryReuseRunner functionality. Signed-off-by: Eli Uriegas <[email protected]> ghstack-source-id: 3d9260c ghstack-comment-id: 3046573503 Pull-Request: #6893
facebook-github-bot
added
the
CLA Signed
Adds terraform files required for deploying scale-cycle. This also adds a switch to turn on scale-cycle or not with the default position being off. This should make it easier to deploy scale-cycle in the future and could also act as a gate for easily enabling / disabling scale-up's tryReuseRunner functionality. Signed-off-by: Eli Uriegas <[email protected]> ghstack-source-id: 87583f4 ghstack-comment-id: 3046573503 Pull-Request: #6893 Signed-off-by: Eli Uriegas <[email protected]>
| @@ -374,6 +374,24 @@ variable "retry_scale_up_chron_hud_query_url" { | |||
| default = "" | |||
| } | |||
|
|
|||
| variable "enable_scale_cycle" { | |||
There was a problem hiding this comment.
nit: enabling could be inferred based on whether scale_cycle_schedule_expression set
| "ec2:CreateNetworkInterface", | ||
| "ec2:DescribeNetworkInterfaces", | ||
| "ec2:DeleteNetworkInterface", |
There was a problem hiding this comment.
Are these actually needed? I do see that scale up has these as well, but it seems odd that they'd require this permission.
There was a problem hiding this comment.
I think this is techincally what is needed to create an EC2 instance
There was a problem hiding this comment.
I believe this is only necessary if we need more complex networking outside of what EC2 instance launch creates when you create a new EC2 instance. Like an instance with multiple NICs connected to more than 1 network.
Edit: I think ec2:RunInstance already creates the default NIC.
| "ec2:CreateTags", | ||
| "ec2:DeleteTags", | ||
| "ec2:CreateReplaceRootVolumeTask", | ||
| "ec2:DescribeReplaceRootVolumeTasks" |
There was a problem hiding this comment.
What is this permission needed for? Scale up/down don't use it
Adds terraform files required for deploying scale-cycle. This also adds
a switch to turn on scale-cycle or not with the default position being
off. This should make it easier to deploy scale-cycle in the future and
could also act as a gate for easily enabling / disabling scale-up's
tryReuseRunner functionality.
Signed-off-by: Eli Uriegas [email protected]