[Nova] Windows vision wheels #3932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
facebook-github-bot
added
the
CLA Signed
osalpekar
approved these changes
Mar 30, 2023
| else | ||
| ${CONDA_RUN} bash "${POST_SCRIPT}" | ||
| fi | ||
| ${CONDA_RUN} ${ENV_SCRIPT} ${POST_SCRIPT} |
Member
There was a problem hiding this comment.
Why did we remove this error check?
Contributor
Author
There was a problem hiding this comment.
Post script in this case is "python packaging/wheel/relocate.py", also generally this job is for inside use, I don't see big value of keeping this check I believe if script is not found the job will fail anyways.
Member
There was a problem hiding this comment.
Let's just make sure we're consistent across all the workflows and across pre-script/post-script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should enable windows vision wheels