Enabled DR. CI for vision repo #3842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
DanilBaibak
requested review from
ZainRizvi,
clee2000 and
malfet
and removed request for
ZainRizvi
malfet
previously requested changes
Mar 6, 2023
Contributor
malfet
left a comment
malfet
left a comment
There was a problem hiding this comment.
isPyTorchPyTorch is used from more than one place in the codebase. Also, IMO, this creates a mismatch between function name and behavior.
Please add a new function (say isPyTorchOrTorchvision) or if we want to enable DrCI for all projects in PyTorch org, just use isPyTorchOrg` as guard in drciUtils.ts
ZainRizvi
approved these changes
Mar 7, 2023
Co-authored-by: Zain Rizvi <[email protected]>
seemethere
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled DR. CI for vision repo.