[Feature] Stacking specs #892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
# Conflicts: # test/test_specs.py
Co-authored-by: Tom Begley <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stacking specs is a mileston in allowing for multi-task and multi-agent env wrappers.
This PR introduces two classes:
LazyStackedTensorSpec: represents a stack of tensorspecs. It does not require them to be homogeneous in shape but we don't support different spec type.LazyStackedCompositeSpec, which inherits from the one above, but has extra key-features. Its (random) samples are of theLazyStackedTensorDicttype.The supported operations are:
cloneexpandtorandzeroIndexing can be performed along the stack dimension only. If the indexing is attempted along another dimension, an error will be thrown. This means that a stack of a stack can be indexed but only in the right order.
TODO: