Skip to content

[BugFix] Improve done checking of collectors #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2023
Merged

[BugFix] Improve done checking of collectors #838

merged 1 commit into from
Jan 18, 2023

Conversation

matteobettini
Copy link
Contributor

Description

Check missed from #800

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 17, 2023
vmoens
vmoens approved these changes Jan 17, 2023
View reviewed changes
Copy link
Collaborator

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmoens vmoens merged commit e8e511d into pytorch:main Jan 18, 2023
@vmoens vmoens added the bug Something isn't working label Jan 18, 2023
@matteobettini matteobettini deleted the done branch January 19, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmoens vmoens vmoens approved these changes

Assignees

No one assigned

Labels

bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matteobettini @vmoens @facebook-github-bot