Skip to content

Conversation

arvindcr4
Copy link
Contributor

@arvindcr4 arvindcr4 commented Aug 21, 2025

This PR fixes a minor import issue in the LSTMModule docstring example.

  • Add to the import alongside so the snippet runs as-is without raising a .

Documentation-only change.

Closes #3119

…P in the example import so the snippet runs without NameError.\n\nRefs: pytorch#3119
@Copilot Copilot AI review requested due to automatic review settings August 21, 2025 17:46
Copy link

pytorch-bot bot commented Aug 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3138

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures, 2 Cancelled Jobs, 16 Unrelated Failures

As of commit bb07f7c with merge base 2f65671 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 21, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a missing import in the LSTM example docstring to ensure the code snippet runs without errors.

  • Add LSTMModule to the import statement alongside MLP in the docstring example

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@vmoens vmoens changed the title docs: fix LSTM example import in rnn.LSTMModule [Doc] fix LSTM example import in rnn.LSTMModule Aug 26, 2025
Copy link
Collaborator

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@vmoens vmoens merged commit f596e53 into pytorch:main Aug 26, 2025
50 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor import typo
2 participants