Skip to content

[BugFix] Fix gym benchmark #1619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2023
Merged

[BugFix] Fix gym benchmark #1619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions benchmarks/ecosystem/gym_env_throughput.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,17 +30,14 @@

if __name__ == "__main__":
for envname in [
"HalfCheetah-v4",
"CartPole-v1",
"HalfCheetah-v4",
"myoHandReachRandom-v0",
"ALE/Breakout-v5",
"CartPole-v1",
]:
# the number of collectors won't affect the resources, just impacts how the envs are split in sub-sub-processes
for num_workers, num_collectors in zip((8, 16, 32, 64), (2, 4, 8, 8)):
with open(
f"atari_{envname}_{num_workers}.txt".replace("/", "-"), "w+"
) as log:
for num_workers, num_collectors in zip((32, 64, 8, 16), (8, 8, 2, 4)):
with open(f"{envname}_{num_workers}.txt".replace("/", "-"), "w+") as log:
if "myo" in envname:
gym_backend = "gym"
else:
Expand Down Expand Up @@ -219,7 +216,7 @@ def make_env(

penv = EnvCreator(
lambda num_workers=num_workers // num_collectors: make_env(
num_workers
num_workers=num_workers
)
)
collector = MultiaSyncDataCollector(
Expand Down Expand Up @@ -306,7 +303,7 @@ def make_env(

penv = EnvCreator(
lambda num_workers=num_workers // num_collectors: make_env(
num_workers
num_workers=num_workers
)
)
collector = MultiSyncDataCollector(
Expand Down