Skip to content

[BugFix] Fix RLHF tests - transformers v4.34 #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2023
Merged

[BugFix] Fix RLHF tests - transformers v4.34 #1601

merged 1 commit into from
Oct 4, 2023

Conversation

vmoens
Copy link
Collaborator

@vmoens vmoens commented Oct 4, 2023 •
edited
Loading

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 4, 2023
@vmoens vmoens added the bug Something isn't working label Oct 4, 2023
matteobettini
matteobettini approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@matteobettini matteobettini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmoens vmoens merged commit 02cd86e into main Oct 4, 2023
@vmoens vmoens deleted the update_transformers_compat branch October 4, 2023 14:54
vmoens pushed a commit to hyerra/rl that referenced this pull request Oct 10, 2023
@vmoens
[BugFix] Fix RLHF tests - transformers v4.34 (pytorch#1601)
b64fa55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@matteobettini matteobettini matteobettini approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vmoens @matteobettini @facebook-github-bot