Skip to content

Conversation

DanilBaibak
Copy link
Contributor

Description

Add macOS M1 binaries Wheels

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 7, 2023
@vmoens vmoens changed the title Add macOS M1 binaries Wheels [CI] Add macOS M1 binaries Wheels Sep 7, 2023
Copy link
Collaborator

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @DanilBaibak
This will be blocked as long as pytorch-labs does not have access to the M1 machines to build its own binaries I'm afraid. We can't have a pypi version of binaries for torchrl if the corresponding tensordict version isn't available.

@vmoens vmoens added the CI Has to do with CI setup (e.g. wheels & builds, tests...) label Sep 7, 2023
@vmoens
Copy link
Collaborator

vmoens commented Sep 12, 2023

@DanilBaibak What is the status of pytorch-labs and GHA runners? Any progress?

@vmoens vmoens added the ciflow/binaries/all Build all binaries label Oct 5, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 5, 2023

No ciflow labels are configured for this repo.
For information on how to enable CIFlow bot see this wiki

Copy link
Collaborator

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmoens vmoens merged commit f09b0c8 into main Oct 5, 2023
@vmoens vmoens deleted the Test-M1-Wheels branch October 5, 2023 15:45
vmoens added a commit to hyerra/rl that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Has to do with CI setup (e.g. wheels & builds, tests...) ciflow/binaries/all Build all binaries CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants