Skip to content

Conversation

@per
Copy link
Collaborator

@per per commented Jan 14, 2025

Remove the 'manual' quantization of bias parameter and let the quantizer handle the quantization instead.

Test plan

Uses Arm backend unit tests for testing.

Remove the 'manual' quantization of bias parameter and let the
quantizer handle the quantization instead.

Signed-off-by: Per Åstrand <[email protected]>
Change-Id: I0130a49973e9357a65930da6b5a83f2b8c458dce
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7649

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 Cancelled Jobs

As of commit 945b2d9 with merge base 25bf93e (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 14, 2025
@per per added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels Jan 14, 2025
@per per requested a review from freddan80 January 14, 2025 13:00
@per
Copy link
Collaborator Author

per commented Jan 14, 2025

  • Cancelled macos jobs not related to this change.
  • check label job has run successfully.

@freddan80 freddan80 merged commit 3ef100d into pytorch:main Jan 15, 2025
105 of 110 checks passed
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
Remove the 'manual' quantization of bias parameter and let the
quantizer handle the quantization instead.

Signed-off-by: Per Åstrand <[email protected]>
@per per deleted the quantize_bias branch January 30, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants