Arm backend: Size adjust conv2d pass improvements #7646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explain more thorougly what the pass does. Change-Id: I9260512fb0b8afe23505edcce47dd3c9f59e9690
The functions insert_q_dq_pair and create_node were duplicates of functions with the same name in arm_pass_utils.py. Import the functions from arm_pass_utils and remove the duplicate functions. Change-Id: I8f16af56f8438d8cd33d087c4ebac419cb5b2596
Change-Id: I84e9cb02f18cb1c81a27156b6e9d946c11291adf
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7646
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2caa156 with merge base 25bf93e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Collaborator
Author
|
@pytorchbot label ciflow/trunk |
Collaborator
Author
|
@pytorchbot label "topic: not user facing" |
Collaborator
Author
|
@pytorchbot label "partner: arm" |
pytorch-bot
bot
added
the
partner: arm
freddan80
approved these changes
Jan 15, 2025
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
[Arm backend] Improve the documentation of the size adjust conv2d pass and remove duplicated code. Also add more tests to conv1d and conv2d that need to go through the pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the documentation of the size adjust conv2d pass and remove duplicated code.
Also add more tests to conv1d and conv2d that need to go through the pass.