Update install_requirements to install --pybind xnnpack by default. #7473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7473
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit fe5d231 with merge base a861294 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
mergennachin
added
the
release notes: build
mergennachin
requested review from
GregoryComer,
cccclai,
dbort,
iseeyuan,
kimishpatel and
mcr229
mergennachin
force-pushed
the
install_xnnpack_by_default
branch
from
a9fd5ce to
683142c
Compare
mergennachin
force-pushed
the
install_xnnpack_by_default
branch
from
683142c to
f951b54
Compare
Summary: Regular ./install_requirements.sh will install pybind xnnpack by default. It is necessary for Llama for instance. It is still backwards compatible with './install_requirements.sh --pybind xnnpack' One can also turn off explicitly by calling './install_requirement.sh --pybind off' Test Plan: Test valid options: ./install_requirements.sh ./install_requirements.sh --pybind xnnpack ./install_requirements.sh --pybind coreml ./install_requirements.sh --pybind coreml xnnpack ./install_requirements.sh --pybind off Invalid options: ./install_requirements.sh xnnpack ./install_requirements.sh --pybind coreml off ./install_requirements.sh --pybind coreml xnnpack off ./install_requirements.sh off
mergennachin
force-pushed
the
install_xnnpack_by_default
branch
from
f951b54 to
fe5d231
Compare
Contributor
|
@mergennachin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mcr229
approved these changes
Jan 3, 2025
Jack-Khuu
added a commit
to pytorch/torchchat
that referenced
this pull request
Jan 24, 2025
ExecuTorch now has XNN pybinding built by default pytorch/executorch#7473 Previously it was not built by default
This was referenced Jan 24, 2025
Merged
Jack-Khuu
added a commit
to pytorch/torchchat
that referenced
this pull request
Jan 24, 2025
) ExecuTorch now has XNN pybinding built by default pytorch/executorch#7473 Previously it was not built by default
vmpuri
pushed a commit
to pytorch/torchchat
that referenced
this pull request
Feb 4, 2025
) ExecuTorch now has XNN pybinding built by default pytorch/executorch#7473 Previously it was not built by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Regular ./install_requirements.sh will install pybind xnnpack by default. It is necessary for Llama for instance.
It is still backwards compatible with './install_requirements.sh --pybind xnnpack'
One can also turn off explicitly by calling './install_requirement.sh --pybind off'
Test Plan:
Test valid options:
./install_requirements.sh
./install_requirements.sh --pybind xnnpack
./install_requirements.sh --pybind coreml
./install_requirements.sh --pybind coreml xnnpack
./install_requirements.sh --pybind off
Invalid options:
./install_requirements.sh xnnpack
./install_requirements.sh --pybind coreml off
./install_requirements.sh --pybind coreml xnnpack off
./install_requirements.sh off
Partially fixes #7460