Skip to content

Conversation

@haowhsu-quic
Copy link
Collaborator

Summary

  • remove _to_dim op and let backend take care of tensor layout
    • Current layout_transform works well.
    • We always use contiguous memory to fetch parameters.
    • Remove this memory format operator won't affect the original output.
  • test cases

Fixes #<4873>

Test plan

python backends/qualcomm/tests/test_qnn_delegate.py -k TestQNNQuantizedOperators.test_qnn_backend_conv2d_channel_last -s $DEVICE_SERIAL -m $SOC_MODEL -b build-android/ -a $PATH_TO_ARTIFACTS

Summary
- remove _to_dim op and let backend take care of tensor layout
- test cases
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 5, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7189

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 6f54df9 with merge base 8861b9a (image):

NEW FAILURE - The following job has failed:

  • pull / unittest-arm / linux-job (gh)
    RuntimeError: Command docker exec -t 01c02038e819a0c5d8cc8c6b785e054635c349a6e2c426d5afc85740d9284226 /exec failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 5, 2024
@dbort dbort requested review from Gasoonjia, cccclai and swolchok and removed request for swolchok December 5, 2024 07:12
@cccclai cccclai added partner: qualcomm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Qualcomm release notes: backends labels Dec 5, 2024
@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cccclai cccclai merged commit 9289b3f into pytorch:main Dec 5, 2024
42 of 45 checks passed
@haowhsu-quic haowhsu-quic deleted the dev_dim_order branch February 7, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: qualcomm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Qualcomm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Call for Action: Supporting Dim Order in Backend Delegates

4 participants