Skip to content

Introduce static targets #6934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Introduce static targets #6934

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions backends/vulkan/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def vulkan_spv_shader_lib(name, spv_filegroups, is_fbcode = False, no_volk = Fal
compiler_flags = get_vulkan_compiler_flags(),
labels = get_labels(no_volk),
platforms = get_platforms(no_volk),
define_static_target = False,
define_static_target = True,
# Static initialization is used to register shaders to the global shader registry,
# therefore link_whole must be True to make sure unused symbols are not discarded.
# @lint-ignore BUCKLINT: Avoid `link_whole=True`
Expand Down Expand Up @@ -197,7 +197,7 @@ def define_common_targets(is_fbcode = False):
exported_deps = [
":vulkan_graph_runtime_shaderlib{}".format(suffix),
],
define_static_target = False,
define_static_target = True,
# Static initialization is used to register operators to the global operator registry,
# therefore link_whole must be True to make sure unused symbols are not discarded.
# @lint-ignore BUCKLINT: Avoid `link_whole=True`
Expand All @@ -215,7 +215,6 @@ def define_common_targets(is_fbcode = False):
no_volk = no_volk,
)


runtime.cxx_library(
name = "vulkan_backend_lib{}".format(suffix),
srcs = native.glob([
Expand All @@ -240,7 +239,7 @@ def define_common_targets(is_fbcode = False):
"//executorch/runtime/backend:interface",
"//executorch/runtime/core/exec_aten/util:tensor_util",
],
define_static_target = False,
define_static_target = True,
# VulkanBackend.cpp needs to compile with executor as whole
# @lint-ignore BUCKLINT: Avoid `link_whole=True` (https://fburl.com/avoid-link-whole)
link_whole = True,
Expand Down
Loading