Skip to content

Arm backend: Add select operator #6389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 29, 2024
Merged

Arm backend: Add select operator #6389

merged 3 commits into from
Oct 29, 2024

Conversation

@SaoirseARM
Copy link
Collaborator

@SaoirseARM SaoirseARM commented Oct 21, 2024

Adds Select operator to the Arm backend including unit tests

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 21, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6389

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1bcb626 with merge base cbfdf78 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 21, 2024
@SaoirseARM
Copy link
Collaborator Author

SaoirseARM commented Oct 21, 2024

@pytorchbot label ciflow/trunk

@SaoirseARM
Copy link
Collaborator Author

SaoirseARM commented Oct 21, 2024

@pytorchbot label 'partner: arm'

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Oct 21, 2024
digantdesai
digantdesai approved these changes Oct 22, 2024
View reviewed changes
backends/arm/operators/op_select.py

@register_node_visitor
class SelectVisitor(NodeVisitor):
target = "aten.select_copy.int"
Copy link
Contributor

@digantdesai digantdesai Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can't replace this with slice easily in a pass?

Copy link
Collaborator Author

@SaoirseARM SaoirseARM Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Thanks for review!
We could use a pass for this, but there is some work that is on-going that should enable this going forward.
I hope this helps!

Thanks,
Saoirse

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 22, 2024

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@digantdesai
Copy link
Contributor

digantdesai commented Oct 23, 2024

Ci failures?

@SaoirseARM
Copy link
Collaborator Author

SaoirseARM commented Oct 24, 2024

Ci failures?
Ah, thank you! It needed a rebase.

  • Saoirse

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 28, 2024

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot merged commit 2c32bf3 into pytorch:main Oct 29, 2024
109 of 110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesai digantdesai digantdesai approved these changes

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SaoirseARM @facebook-github-bot @digantdesai