Skip to content

Add pass for decomposing (log)softmax #6287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2024
Merged

Add pass for decomposing (log)softmax #6287

merged 1 commit into from
Oct 24, 2024

Conversation

@Erik-Lundell
Copy link
Collaborator

@Erik-Lundell Erik-Lundell commented Oct 16, 2024

Change-Id: Ifda9b5a557ee29af5abc64569c51ec6bd6421c66

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 16, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6287

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8a7be5c with merge base f6778d5 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 16, 2024
@Erik-Lundell Erik-Lundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Oct 16, 2024
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 16, 2024
digantdesai
digantdesai approved these changes Oct 16, 2024
View reviewed changes
backends/arm/_passes/decompose_softmaxes_pass.py
"""
if op in edge_softmax:
return (
exir_ops.edge.aten.log.default,
Copy link
Contributor

@digantdesai digantdesai Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit can we use getattr and string concat?

Copy link
Collaborator Author

@Erik-Lundell Erik-Lundell Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a neat suggestion, I'll keep it in mind when implementing a similar decomposition in the future

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 16, 2024

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

3 similar comments
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 17, 2024

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 21, 2024

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 22, 2024

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@digantdesai
Copy link
Contributor

digantdesai commented Oct 22, 2024

Rebase please?

@Erik-Lundell
Add pass for decomposing (log)softmax
8a7be5c 
Signed-off-by: Erik Lundell <[email protected]>
Change-Id: Ifda9b5a557ee29af5abc64569c51ec6bd6421c66
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 23, 2024

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot merged commit d695f15 into pytorch:main Oct 24, 2024
107 of 108 checks passed
@Erik-Lundell Erik-Lundell deleted the op_softmax branch July 31, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesai digantdesai digantdesai approved these changes

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Erik-Lundell @facebook-github-bot @digantdesai