Move examples/mediatek out from under the torch namespace #5478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5478
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 85190a1 with merge base af098c3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
@dbort has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@neuropilot-captain could you help confirm it's still working? We don't have ci have mediatek backend yet and will need some manual verification |
dbort
force-pushed
the
examples-mediatek
branch
from
be09cb7 to
85190a1
Compare
Contributor
|
@dbort has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Collaborator
|
Looks good! Built successfully |
JacobSzwejbka
approved these changes
Sep 23, 2024
cccclai
approved these changes
Sep 23, 2024
Contributor
Contributor
Author
|
@pytorchbot cherry-pick --onto release/0.4 -c fixnewfeature |
pytorchbot
pushed a commit
that referenced
this pull request
Sep 23, 2024
Summary: The code under examples/... is a proxy for user code, and users should never declare code under the `torch::` or `executorch::` namespaces. Move this code under the `example::` namespace to make it more clear that users should use their own namespaces when writing code like this. Pull Request resolved: #5478 Test Plan: - Built using the instructions at https://github.com/pytorch/executorch/blob/main/examples/mediatek/README.md Reviewed By: JacobSzwejbka, cccclai Differential Revision: D62992974 Pulled By: dbort fbshipit-source-id: b01f1b33d2853a0555ae19d79769a5bb6d0ba853 (cherry picked from commit 182f138)
Collaborator
Cherry picking #5478The cherry pick PR is at #5556 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
jackzhxng
pushed a commit
that referenced
this pull request
Sep 24, 2024
Move examples/mediatek out from under the torch namespace (#5478) Summary: The code under examples/... is a proxy for user code, and users should never declare code under the `torch::` or `executorch::` namespaces. Move this code under the `example::` namespace to make it more clear that users should use their own namespaces when writing code like this. Pull Request resolved: #5478 Test Plan: - Built using the instructions at https://github.com/pytorch/executorch/blob/main/examples/mediatek/README.md Reviewed By: JacobSzwejbka, cccclai Differential Revision: D62992974 Pulled By: dbort fbshipit-source-id: b01f1b33d2853a0555ae19d79769a5bb6d0ba853 (cherry picked from commit 182f138) Co-authored-by: Dave Bort <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code under examples/... is a proxy for user code, and users should never declare code under the
torch::orexecutorch::namespaces.Move this code under the
example::namespace to make it more clear that users should use their own namespaces when writing code like this.Test Plan: