Skip to content

Conversation

roman-janik-nxp
Copy link
Collaborator

@roman-janik-nxp roman-janik-nxp commented Oct 6, 2025

Summary

This PR replaces optimizations 'fuse_activation_functions.py' by quantization of Conv 2D and Linear ops together with fusable activations - selected activations supported by Neutron (Relu, Relu6, Sigmoid, Tanh). Logic is determined by target specs, now supporting Neutron-C. Tests updated. Relu has now non-shared, standalone quantization.

Test plan

Unit tests provided (test_edge_passes.py, test_quantizer.py).

cc @robert-kalmar @JakeStevens @digantdesai

Copy link

pytorch-bot bot commented Oct 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14816

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures

As of commit 8d9107b with merge base 2c603e4 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 6, 2025
@roman-janik-nxp
Copy link
Collaborator Author

@pytorchbot label "module: nxp" "release notes: nxp"

@pytorch-bot pytorch-bot bot added module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate labels Oct 6, 2025
exir_ops.edge.aten.hardtanh.default,
exir_ops.edge.aten.relu.default,
exir_ops.edge.aten.sigmoid.default,
exir_ops.edge.aten.tanh.default,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary?
I would expect that since the Move*AuxiliaryOperatorIntoSeparateQDQClusterPass now supports these operators, they should be the main nodes within their own QDQ clusters.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked into into it. The reason is it's in the QDQClusterRecognizer AUXILIARY_OPS list not only for the use in partitioner, but because the QDQClusterRecognizer is also used in the Move*AuxiliaryOperatorIntoSeparateQDQClusterPass:

cluster = QDQClusterRecognizer().get_qdq_cluster(main_cluster_node)

@roman-janik-nxp roman-janik-nxp force-pushed the feature/nxg11066/EIEX-469-EIEX-470-Replace-pass-to-fuse-activations-functions_github branch from 6fdef26 to 33f153a Compare October 9, 2025 10:01
+ Move fused activations to separate QDQ cluster
@roman-janik-nxp roman-janik-nxp force-pushed the feature/nxg11066/EIEX-469-EIEX-470-Replace-pass-to-fuse-activations-functions_github branch from 33f153a to 8d9107b Compare October 9, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants