Skip to content

Conversation

@jathu
Copy link
Contributor

@jathu jathu commented May 9, 2025

Summary

  • Remove the ability to set flatc using FLATC_EXECUTABLE and always build it from source
    • Also remove, the now redundant, EXECUTORCH_BUILD_FLATC
  • Move the flatc configuration into third-party/CMakeLists.txt to keep things organized
  • Allow FLATBUFFERS_MAX_ALIGNMENT to be configurable

Test plan

CI

cc @larryliu0820

@jathu jathu requested a review from larryliu0820 May 9, 2025 04:07
@pytorch-bot
Copy link

pytorch-bot bot commented May 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10781

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Pending

As of commit ce4507c with merge base 6e959be (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 9, 2025
@jathu jathu added module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch ciflow/trunk ciflow/binaries release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. labels May 9, 2025
@jathu jathu force-pushed the jathu/remove-flatc-executable branch 4 times, most recently from 275837c to 5f62193 Compare May 9, 2025 16:19
@jathu jathu force-pushed the jathu/remove-flatc-executable branch from 5f62193 to ce4507c Compare May 9, 2025 20:40
@jathu jathu marked this pull request as ready for review May 9, 2025 21:16
@jathu jathu requested a review from kirklandsign May 9, 2025 21:16
set_target_properties(flatc PROPERTIES IMPORTED_LOCATION ${BINARY_DIR}/flatc)
endif()

# TODO: re-enable once flatbuffers is added as a subdirectory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to stop directly reaching into flatbuffers, and instead use the flatbuffer library target:

"${EXECUTORCH_ROOT}/third-party/flatbuffers/include"

I'll do it in some future diff

@jathu jathu merged commit 1c2b7ba into main May 9, 2025
208 of 209 checks passed
@jathu jathu deleted the jathu/remove-flatc-executable branch May 9, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants